Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1931813002: Propagate googScreencastMinBitrate constraint to webrtc's RTCConfiguration. (Closed)

Created:
4 years, 7 months ago by nisse-chromium (ooo August 14)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Propagate googScreencastMinBitrate constraint to webrtc's RTCConfiguration. BUG=607503 Committed: https://crrev.com/dd7121647559c1618171f4f11ffe910a14fc93f9 Cr-Commit-Position: refs/heads/master@{#390642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M content/renderer/media/rtc_peer_connection_handler.cc View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
nisse-chromium (ooo August 14)
This cl fixes the screencast_min_bitrate on chrome master. Should probably be merged into M51.
4 years, 7 months ago (2016-04-28 11:25:05 UTC) #2
perkj_chrome
lgtm
4 years, 7 months ago (2016-04-28 12:01:24 UTC) #4
hta - Chromium
lgtm
4 years, 7 months ago (2016-04-29 07:01:18 UTC) #6
sprang_chromium
lgtm
4 years, 7 months ago (2016-04-29 13:22:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931813002/1
4 years, 7 months ago (2016-04-29 13:24:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 14:12:22 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:25:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd7121647559c1618171f4f11ffe910a14fc93f9
Cr-Commit-Position: refs/heads/master@{#390642}

Powered by Google App Engine
This is Rietveld 408576698