content/renderer/render_frame_impl.h - Issue 1931793002: Stop using nested message loop for alert() and other JS dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1931793002: Stop using nested message loop for alert() and other JS dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use infinite loop instead of 10 secs Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 6dbdbb107ceadf21126e1f73a0104621d9a4861a..e9cbf90614c37245dd1f07cb3e52ac0abcdd2c67 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -856,7 +856,7 @@ class CONTENT_EXPORT RenderFrameImpl

void SyncSelectionIfRequired();

// Sends a message and runs a nested message loop.

Lei Zhang 2016/05/03 18:02:10 Update comment?

Changwan Ryu 2016/05/10 01:49:21 Done.

- bool SendAndRunNestedMessageLoop(IPC::SyncMessage* message);

+ bool SendSyncMessage(IPC::SyncMessage* message);

bool RunJavaScriptMessage(JavaScriptMessageType type,

const base::string16& message,