Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: content/renderer/render_thread_impl.h

Issue 1931793002: Stop using nested message loop for alert() and other JS dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_THREAD_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_THREAD_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 cc::TaskGraphRunner* GetTaskGraphRunner() override; 216 cc::TaskGraphRunner* GetTaskGraphRunner() override;
217 bool AreImageDecodeTasksEnabled() override; 217 bool AreImageDecodeTasksEnabled() override;
218 bool IsThreadedAnimationEnabled() override; 218 bool IsThreadedAnimationEnabled() override;
219 219
220 // Synchronously establish a channel to the GPU plugin if not previously 220 // Synchronously establish a channel to the GPU plugin if not previously
221 // established or if it has been lost (for example if the GPU plugin crashed). 221 // established or if it has been lost (for example if the GPU plugin crashed).
222 // If there is a pending asynchronous request, it will be completed by the 222 // If there is a pending asynchronous request, it will be completed by the
223 // time this routine returns. 223 // time this routine returns.
224 scoped_refptr<gpu::GpuChannelHost> EstablishGpuChannelSync(CauseForGpuLaunch); 224 scoped_refptr<gpu::GpuChannelHost> EstablishGpuChannelSync(CauseForGpuLaunch);
225 225
226 // This method modifies how the next message is sent. Normally, when sending
227 // a synchronous message that runs a nested message loop, we need to suspend
228 // callbacks into WebKit. This involves disabling timers and deferring
229 // resource loads. However, there are exceptions when we need to customize
230 // the behavior.
231 void DoNotNotifyWebKitOfModalLoop();
232
233 // True if we are running layout tests. This currently disables forwarding 226 // True if we are running layout tests. This currently disables forwarding
234 // various status messages to the console, skips network error pages, and 227 // various status messages to the console, skips network error pages, and
235 // short circuits size update and focus events. 228 // short circuits size update and focus events.
236 bool layout_test_mode() const { 229 bool layout_test_mode() const {
237 return layout_test_mode_; 230 return layout_test_mode_;
238 } 231 }
239 void set_layout_test_mode(bool layout_test_mode) { 232 void set_layout_test_mode(bool layout_test_mode) {
240 layout_test_mode_ = layout_test_mode; 233 layout_test_mode_ = layout_test_mode;
241 } 234 }
242 235
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
567 560
568 // The count of hidden RenderWidgets running through this thread. 561 // The count of hidden RenderWidgets running through this thread.
569 int hidden_widget_count_; 562 int hidden_widget_count_;
570 563
571 // The current value of the idle notification timer delay. 564 // The current value of the idle notification timer delay.
572 int64_t idle_notification_delay_in_ms_; 565 int64_t idle_notification_delay_in_ms_;
573 566
574 // The number of idle handler calls that skip sending idle notifications. 567 // The number of idle handler calls that skip sending idle notifications.
575 int idle_notifications_to_skip_; 568 int idle_notifications_to_skip_;
576 569
577 bool notify_webkit_of_modal_loop_;
578 bool webkit_shared_timer_suspended_; 570 bool webkit_shared_timer_suspended_;
579 571
580 // The following flag is used to control layout test specific behavior. 572 // The following flag is used to control layout test specific behavior.
581 bool layout_test_mode_; 573 bool layout_test_mode_;
582 574
583 // Timer that periodically calls IdleHandler. 575 // Timer that periodically calls IdleHandler.
584 base::RepeatingTimer idle_timer_; 576 base::RepeatingTimer idle_timer_;
585 577
586 // The channel from the renderer process to the GPU process. 578 // The channel from the renderer process to the GPU process.
587 scoped_refptr<gpu::GpuChannelHost> gpu_channel_; 579 scoped_refptr<gpu::GpuChannelHost> gpu_channel_;
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
702 DISALLOW_COPY_AND_ASSIGN(RenderThreadImpl); 694 DISALLOW_COPY_AND_ASSIGN(RenderThreadImpl);
703 }; 695 };
704 696
705 #if defined(COMPILER_MSVC) 697 #if defined(COMPILER_MSVC)
706 #pragma warning(pop) 698 #pragma warning(pop)
707 #endif 699 #endif
708 700
709 } // namespace content 701 } // namespace content
710 702
711 #endif // CONTENT_RENDERER_RENDER_THREAD_IMPL_H_ 703 #endif // CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698