Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 1931793002: Stop using nested message loop for alert() and other JS dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 495 matching lines...) Expand 10 before | Expand all | Expand 10 after
506 void ShowFirstRunBubble(); 506 void ShowFirstRunBubble();
507 507
508 ExclusiveAccessManager* exclusive_access_manager() { 508 ExclusiveAccessManager* exclusive_access_manager() {
509 return exclusive_access_manager_.get(); 509 return exclusive_access_manager_.get();
510 } 510 }
511 511
512 extensions::WindowController* extension_window_controller() const { 512 extensions::WindowController* extension_window_controller() const {
513 return extension_window_controller_.get(); 513 return extension_window_controller_.get();
514 } 514 }
515 515
516 bool ShouldRunUnloadListenerBeforeClosing(content::WebContents* web_contents);
517 bool RunUnloadListenerBeforeClosing(content::WebContents* web_contents);
518
516 private: 519 private:
517 friend class BrowserTest; 520 friend class BrowserTest;
518 friend class FullscreenControllerInteractiveTest; 521 friend class FullscreenControllerInteractiveTest;
519 friend class FullscreenControllerTest; 522 friend class FullscreenControllerTest;
520 FRIEND_TEST_ALL_PREFIXES(AppModeTest, EnableAppModeTest); 523 FRIEND_TEST_ALL_PREFIXES(AppModeTest, EnableAppModeTest);
521 FRIEND_TEST_ALL_PREFIXES(BrowserCommandControllerTest, 524 FRIEND_TEST_ALL_PREFIXES(BrowserCommandControllerTest,
522 IsReservedCommandOrKeyIsApp); 525 IsReservedCommandOrKeyIsApp);
523 FRIEND_TEST_ALL_PREFIXES(BrowserCommandControllerTest, AppFullScreen); 526 FRIEND_TEST_ALL_PREFIXES(BrowserCommandControllerTest, AppFullScreen);
524 FRIEND_TEST_ALL_PREFIXES(BrowserTest, NoTabsInPopups); 527 FRIEND_TEST_ALL_PREFIXES(BrowserTest, NoTabsInPopups);
525 FRIEND_TEST_ALL_PREFIXES(BrowserTest, ConvertTabToAppShortcut); 528 FRIEND_TEST_ALL_PREFIXES(BrowserTest, ConvertTabToAppShortcut);
(...skipping 488 matching lines...) Expand 10 before | Expand all | Expand 10 after
1014 // The following factory is used for chrome update coalescing. 1017 // The following factory is used for chrome update coalescing.
1015 base::WeakPtrFactory<Browser> chrome_updater_factory_; 1018 base::WeakPtrFactory<Browser> chrome_updater_factory_;
1016 1019
1017 // The following factory is used to close the frame at a later time. 1020 // The following factory is used to close the frame at a later time.
1018 base::WeakPtrFactory<Browser> weak_factory_; 1021 base::WeakPtrFactory<Browser> weak_factory_;
1019 1022
1020 DISALLOW_COPY_AND_ASSIGN(Browser); 1023 DISALLOW_COPY_AND_ASSIGN(Browser);
1021 }; 1024 };
1022 1025
1023 #endif // CHROME_BROWSER_UI_BROWSER_H_ 1026 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698