Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 1931793002: Stop using nested message loop for alert() and other JS dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 838 matching lines...) Expand 10 before | Expand all | Expand 10 after
849 void UpdateEncoding(blink::WebFrame* frame, 849 void UpdateEncoding(blink::WebFrame* frame,
850 const std::string& encoding_name); 850 const std::string& encoding_name);
851 851
852 // Dispatches the current state of selection on the webpage to the browser if 852 // Dispatches the current state of selection on the webpage to the browser if
853 // it has changed. 853 // it has changed.
854 // TODO(varunjain): delete this method once we figure out how to keep 854 // TODO(varunjain): delete this method once we figure out how to keep
855 // selection handles in sync with the webpage. 855 // selection handles in sync with the webpage.
856 void SyncSelectionIfRequired(); 856 void SyncSelectionIfRequired();
857 857
858 // Sends a message and runs a nested message loop. 858 // Sends a message and runs a nested message loop.
859 bool SendAndRunNestedMessageLoop(IPC::SyncMessage* message); 859 bool SendSyncMessage(IPC::SyncMessage* message);
860 860
861 bool RunJavaScriptMessage(JavaScriptMessageType type, 861 bool RunJavaScriptMessage(JavaScriptMessageType type,
862 const base::string16& message, 862 const base::string16& message,
863 const base::string16& default_value, 863 const base::string16& default_value,
864 const GURL& frame_url, 864 const GURL& frame_url,
865 base::string16* result); 865 base::string16* result);
866 866
867 // Loads the appropriate error page for the specified failure into the frame. 867 // Loads the appropriate error page for the specified failure into the frame.
868 void LoadNavigationErrorPage(const blink::WebURLRequest& failed_request, 868 void LoadNavigationErrorPage(const blink::WebURLRequest& failed_request,
869 const blink::WebURLError& error, 869 const blink::WebURLError& error,
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
1215 FrameBlameContext* blame_context_; // Not owned. 1215 FrameBlameContext* blame_context_; // Not owned.
1216 1216
1217 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1217 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1218 1218
1219 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1219 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1220 }; 1220 };
1221 1221
1222 } // namespace content 1222 } // namespace content
1223 1223
1224 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1224 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698