Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: content/renderer/render_thread_impl.h

Issue 1931793002: Stop using nested message loop for alert() and other JS dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated comments and removed unused declaration Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_THREAD_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_THREAD_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 cc::TaskGraphRunner* GetTaskGraphRunner() override; 217 cc::TaskGraphRunner* GetTaskGraphRunner() override;
218 bool AreImageDecodeTasksEnabled() override; 218 bool AreImageDecodeTasksEnabled() override;
219 bool IsThreadedAnimationEnabled() override; 219 bool IsThreadedAnimationEnabled() override;
220 220
221 // Synchronously establish a channel to the GPU plugin if not previously 221 // Synchronously establish a channel to the GPU plugin if not previously
222 // established or if it has been lost (for example if the GPU plugin crashed). 222 // established or if it has been lost (for example if the GPU plugin crashed).
223 // If there is a pending asynchronous request, it will be completed by the 223 // If there is a pending asynchronous request, it will be completed by the
224 // time this routine returns. 224 // time this routine returns.
225 scoped_refptr<gpu::GpuChannelHost> EstablishGpuChannelSync(CauseForGpuLaunch); 225 scoped_refptr<gpu::GpuChannelHost> EstablishGpuChannelSync(CauseForGpuLaunch);
226 226
227 // This method modifies how the next message is sent. Normally, when sending
228 // a synchronous message that runs a nested message loop, we need to suspend
229 // callbacks into WebKit. This involves disabling timers and deferring
230 // resource loads. However, there are exceptions when we need to customize
231 // the behavior.
232 void DoNotNotifyWebKitOfModalLoop();
233
234 // True if we are running layout tests. This currently disables forwarding 227 // True if we are running layout tests. This currently disables forwarding
235 // various status messages to the console, skips network error pages, and 228 // various status messages to the console, skips network error pages, and
236 // short circuits size update and focus events. 229 // short circuits size update and focus events.
237 bool layout_test_mode() const { 230 bool layout_test_mode() const {
238 return layout_test_mode_; 231 return layout_test_mode_;
239 } 232 }
240 void set_layout_test_mode(bool layout_test_mode) { 233 void set_layout_test_mode(bool layout_test_mode) {
241 layout_test_mode_ = layout_test_mode; 234 layout_test_mode_ = layout_test_mode;
242 } 235 }
243 236
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
574 567
575 // The count of hidden RenderWidgets running through this thread. 568 // The count of hidden RenderWidgets running through this thread.
576 int hidden_widget_count_; 569 int hidden_widget_count_;
577 570
578 // The current value of the idle notification timer delay. 571 // The current value of the idle notification timer delay.
579 int64_t idle_notification_delay_in_ms_; 572 int64_t idle_notification_delay_in_ms_;
580 573
581 // The number of idle handler calls that skip sending idle notifications. 574 // The number of idle handler calls that skip sending idle notifications.
582 int idle_notifications_to_skip_; 575 int idle_notifications_to_skip_;
583 576
584 bool notify_webkit_of_modal_loop_;
585 bool webkit_shared_timer_suspended_; 577 bool webkit_shared_timer_suspended_;
586 578
587 // The following flag is used to control layout test specific behavior. 579 // The following flag is used to control layout test specific behavior.
588 bool layout_test_mode_; 580 bool layout_test_mode_;
589 581
590 // Timer that periodically calls IdleHandler. 582 // Timer that periodically calls IdleHandler.
591 base::RepeatingTimer idle_timer_; 583 base::RepeatingTimer idle_timer_;
592 584
593 // The channel from the renderer process to the GPU process. 585 // The channel from the renderer process to the GPU process.
594 scoped_refptr<gpu::GpuChannelHost> gpu_channel_; 586 scoped_refptr<gpu::GpuChannelHost> gpu_channel_;
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
712 DISALLOW_COPY_AND_ASSIGN(RenderThreadImpl); 704 DISALLOW_COPY_AND_ASSIGN(RenderThreadImpl);
713 }; 705 };
714 706
715 #if defined(COMPILER_MSVC) 707 #if defined(COMPILER_MSVC)
716 #pragma warning(pop) 708 #pragma warning(pop)
717 #endif 709 #endif
718 710
719 } // namespace content 711 } // namespace content
720 712
721 #endif // CONTENT_RENDERER_RENDER_THREAD_IMPL_H_ 713 #endif // CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
OLDNEW
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698