Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 1931793002: Stop using nested message loop for alert() and other JS dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated comments and removed unused declaration Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 853 matching lines...) Expand 10 before | Expand all | Expand 10 after
864 // finally get right encoding of page. 864 // finally get right encoding of page.
865 void UpdateEncoding(blink::WebFrame* frame, 865 void UpdateEncoding(blink::WebFrame* frame,
866 const std::string& encoding_name); 866 const std::string& encoding_name);
867 867
868 // Dispatches the current state of selection on the webpage to the browser if 868 // Dispatches the current state of selection on the webpage to the browser if
869 // it has changed. 869 // it has changed.
870 // TODO(varunjain): delete this method once we figure out how to keep 870 // TODO(varunjain): delete this method once we figure out how to keep
871 // selection handles in sync with the webpage. 871 // selection handles in sync with the webpage.
872 void SyncSelectionIfRequired(); 872 void SyncSelectionIfRequired();
873 873
874 // Sends a message and runs a nested message loop.
875 bool SendAndRunNestedMessageLoop(IPC::SyncMessage* message);
876
877 bool RunJavaScriptMessage(JavaScriptMessageType type, 874 bool RunJavaScriptMessage(JavaScriptMessageType type,
878 const base::string16& message, 875 const base::string16& message,
879 const base::string16& default_value, 876 const base::string16& default_value,
880 const GURL& frame_url, 877 const GURL& frame_url,
881 base::string16* result); 878 base::string16* result);
882 879
883 // Loads the appropriate error page for the specified failure into the frame. 880 // Loads the appropriate error page for the specified failure into the frame.
884 void LoadNavigationErrorPage(const blink::WebURLRequest& failed_request, 881 void LoadNavigationErrorPage(const blink::WebURLRequest& failed_request,
885 const blink::WebURLError& error, 882 const blink::WebURLError& error,
886 bool replace); 883 bool replace);
(...skipping 352 matching lines...) Expand 10 before | Expand all | Expand 10 after
1239 #endif 1236 #endif
1240 1237
1241 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1238 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1242 1239
1243 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1240 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1244 }; 1241 };
1245 1242
1246 } // namespace content 1243 } // namespace content
1247 1244
1248 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1245 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698