Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 1931793002: Stop using nested message loop for alert() and other JS dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated comments and removed unused declaration Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/content_script_apitest.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 void ShowFirstRunBubble(); 504 void ShowFirstRunBubble();
505 505
506 ExclusiveAccessManager* exclusive_access_manager() { 506 ExclusiveAccessManager* exclusive_access_manager() {
507 return exclusive_access_manager_.get(); 507 return exclusive_access_manager_.get();
508 } 508 }
509 509
510 extensions::WindowController* extension_window_controller() const { 510 extensions::WindowController* extension_window_controller() const {
511 return extension_window_controller_.get(); 511 return extension_window_controller_.get();
512 } 512 }
513 513
514 bool ShouldRunUnloadListenerBeforeClosing(content::WebContents* web_contents);
515 bool RunUnloadListenerBeforeClosing(content::WebContents* web_contents);
516
514 private: 517 private:
515 friend class BrowserTest; 518 friend class BrowserTest;
516 friend class FullscreenControllerInteractiveTest; 519 friend class FullscreenControllerInteractiveTest;
517 friend class FullscreenControllerTest; 520 friend class FullscreenControllerTest;
518 FRIEND_TEST_ALL_PREFIXES(AppModeTest, EnableAppModeTest); 521 FRIEND_TEST_ALL_PREFIXES(AppModeTest, EnableAppModeTest);
519 FRIEND_TEST_ALL_PREFIXES(BrowserCommandControllerTest, 522 FRIEND_TEST_ALL_PREFIXES(BrowserCommandControllerTest,
520 IsReservedCommandOrKeyIsApp); 523 IsReservedCommandOrKeyIsApp);
521 FRIEND_TEST_ALL_PREFIXES(BrowserCommandControllerTest, AppFullScreen); 524 FRIEND_TEST_ALL_PREFIXES(BrowserCommandControllerTest, AppFullScreen);
522 FRIEND_TEST_ALL_PREFIXES(BrowserTest, NoTabsInPopups); 525 FRIEND_TEST_ALL_PREFIXES(BrowserTest, NoTabsInPopups);
523 FRIEND_TEST_ALL_PREFIXES(BrowserTest, ConvertTabToAppShortcut); 526 FRIEND_TEST_ALL_PREFIXES(BrowserTest, ConvertTabToAppShortcut);
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
1008 // The following factory is used for chrome update coalescing. 1011 // The following factory is used for chrome update coalescing.
1009 base::WeakPtrFactory<Browser> chrome_updater_factory_; 1012 base::WeakPtrFactory<Browser> chrome_updater_factory_;
1010 1013
1011 // The following factory is used to close the frame at a later time. 1014 // The following factory is used to close the frame at a later time.
1012 base::WeakPtrFactory<Browser> weak_factory_; 1015 base::WeakPtrFactory<Browser> weak_factory_;
1013 1016
1014 DISALLOW_COPY_AND_ASSIGN(Browser); 1017 DISALLOW_COPY_AND_ASSIGN(Browser);
1015 }; 1018 };
1016 1019
1017 #endif // CHROME_BROWSER_UI_BROWSER_H_ 1020 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/content_script_apitest.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698