Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1931733002: Simplify FontCache::createTypeface (Closed)

Created:
4 years, 7 months ago by eae
Modified:
4 years, 7 months ago
Reviewers:
kojii
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify FontCache::createTypeface Share code between Linux and Windows in FontCache::createTypeface given that both now use the SkFontManager interface. BUG=579678 R=kojii@chromium.org Committed: https://crrev.com/bd63d3b845f72c8e43723b505bd644bdacb15b68 Cr-Commit-Position: refs/heads/master@{#390279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eae
4 years, 7 months ago (2016-04-28 01:14:08 UTC) #1
kojii
lgtm
4 years, 7 months ago (2016-04-28 01:26:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931733002/1
4 years, 7 months ago (2016-04-28 01:29:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 02:45:45 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:15:41 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bd63d3b845f72c8e43723b505bd644bdacb15b68
Cr-Commit-Position: refs/heads/master@{#390279}

Powered by Google App Engine
This is Rietveld 408576698