Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1931723002: fuzzer for net::NormalizeName (Closed)

Created:
4 years, 7 months ago by mattm
Modified:
4 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fuzzer for net::NormalizeName BUG= Committed: https://crrev.com/2c637da4df1dffc7412fb801cc670ea76b811879 Cr-Commit-Position: refs/heads/master@{#390281}

Patch Set 1 #

Patch Set 2 : add //base dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M net/BUILD.gn View 1 1 chunk +10 lines, -0 lines 0 comments Download
A net/cert/internal/verify_name_match_normalizename_fuzzer.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mattm
Not sure if the second half (checking the renormalizing) is useful, wdyt?
4 years, 7 months ago (2016-04-28 01:14:27 UTC) #2
eroman
I think re-checking the normalization is totally legit, sgtm!
4 years, 7 months ago (2016-04-28 01:37:33 UTC) #3
eroman
LGTM. Note that if ever this grows an ICU dependency (maybe for handling text encodings), ...
4 years, 7 months ago (2016-04-28 01:38:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931723002/20001
4 years, 7 months ago (2016-04-28 02:03:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 02:56:12 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2c637da4df1dffc7412fb801cc670ea76b811879 Cr-Commit-Position: refs/heads/master@{#390281}
4 years, 7 months ago (2016-04-30 17:15:44 UTC) #9
mmoroz
The same situation as for socks fuzzers. Speed is fine, but coverage is low and ...
4 years, 7 months ago (2016-05-04 15:21:29 UTC) #11
mattm
4 years, 7 months ago (2016-05-04 19:53:55 UTC) #12
Message was sent while issue was closed.
On 2016/05/04 15:21:29, mmoroz wrote:
> The same situation as for socks fuzzers. Speed is fine, but coverage is low
and
> the fuzzer cannot find new interesting testcases. Would be awesome to have
some
> seed corpus:
>
https://pantheon.corp.google.com/storage/browser/clusterfuzz-corpus/libfuzzer...

I get a "You don't have permission to view the Storage Browser or Storage
Settings pages in this project." error on that link (using my google.com
account). Do I need to request access somehow?

Powered by Google App Engine
This is Rietveld 408576698