Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1931663003: [Findit] Updating run.sh to put the module to test before the path to code coverage (Closed)

Created:
4 years, 7 months ago by lijeffrey
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Updating run.sh to put the module to test before the path to code coverage BUG=607316 Committed: https://chromium.googlesource.com/infra/infra/+/ac13e2acc2d680c9eb570738f2f132bcf45c1a27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M appengine/findit/util_scripts/run.sh View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
lijeffrey
Hey guys, this change fixes the unit tests break. Just a 1-liner, ptal when you ...
4 years, 7 months ago (2016-04-27 21:40:44 UTC) #3
chanli
On 2016/04/27 21:40:44, lijeffrey wrote: > Hey guys, this change fixes the unit tests break. ...
4 years, 7 months ago (2016-04-27 21:42:01 UTC) #4
stgao
lgtm
4 years, 7 months ago (2016-04-27 21:42:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931663003/1
4 years, 7 months ago (2016-04-27 21:42:48 UTC) #7
Sergey Berezin
LGTM, sorry for the breaking change.
4 years, 7 months ago (2016-04-27 21:43:50 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 21:55:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/ac13e2acc2d680c9eb570738f2f13...

Powered by Google App Engine
This is Rietveld 408576698