Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: scripts/slave/recipes/run_presubmit.py

Issue 1931633002: Make use of dry_run property of presubmit tryjobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/run_presubmit.expected/chromium_dry_run.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/run_presubmit.py
diff --git a/scripts/slave/recipes/run_presubmit.py b/scripts/slave/recipes/run_presubmit.py
index ee92b65d9420c959fe2951029dce3c1d6d4b30a7..5ff05cb9bbcc06a905ab3d60a65940e1f925b525 100644
--- a/scripts/slave/recipes/run_presubmit.py
+++ b/scripts/slave/recipes/run_presubmit.py
@@ -78,6 +78,8 @@ def _RunStepsInternal(api):
]
else: # pragma: no cover
assert False, 'patch_storage %s is not supported' % patch_storage
+ if api.properties.get('dry_run'):
+ presubmit_args.append('--dry_run')
presubmit_args.extend([
'--root', abs_root,
@@ -135,6 +137,18 @@ def GenTests(api):
)
yield (
+ api.test('chromium_dry_run') +
+ api.properties.tryserver(
+ mastername='tryserver.chromium.linux',
+ buildername='chromium_presubmit',
+ repo_name='chromium',
+ patch_project='chromium',
+ dry_run=True) +
+ api.step_data('presubmit', api.json.output([['chromium_presubmit',
+ ['compile']]]))
+ )
+
+ yield (
api.test('chromium_with_auth') +
api.properties.tryserver(
mastername='tryserver.chromium.linux',
« no previous file with comments | « no previous file | scripts/slave/recipes/run_presubmit.expected/chromium_dry_run.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698