Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 193163003: Enable use of distance fields via SkPaint flag. (Closed)

Created:
6 years, 9 months ago by jvanverth1
Modified:
6 years, 9 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Enable use of distance fields via SkPaint flag. Now that distance field generation is fast enough to make it practical, this makes distances field fonts easily available to anyone who wants to try them out (i.e Chromium). BUG=skia:2173 Committed: http://code.google.com/p/skia/source/detail?r=13741

Patch Set 1 #

Patch Set 2 : Make it clear that distance field flag is temporary #

Patch Set 3 : Change HACK to TEMP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -54 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/common_variables.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/gpu.gyp View 1 chunk +0 lines, -11 lines 0 comments Download
M gyp/gpu.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M include/core/SkPaint.h View 1 2 3 chunks +15 lines, -1 line 0 comments Download
M src/core/SkPaint.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrTextStrike.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 7 chunks +0 lines, -10 lines 0 comments Download
M src/gpu/GrTextStrike_impl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jvanverth1
6 years, 9 months ago (2014-03-10 20:03:00 UTC) #1
jvanverth1
Updated to make it clear that the distance field flag is temporary. Also implement missing ...
6 years, 9 months ago (2014-03-10 20:30:46 UTC) #2
reed1
api lgtm
6 years, 9 months ago (2014-03-10 20:32:26 UTC) #3
bsalomon
On 2014/03/10 20:32:26, reed1 wrote: > api lgtm lgtm
6 years, 9 months ago (2014-03-10 20:43:46 UTC) #4
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 9 months ago (2014-03-11 16:03:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/193163003/40001
6 years, 9 months ago (2014-03-11 16:03:52 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 17:07:27 UTC) #7
Message was sent while issue was closed.
Change committed as 13741

Powered by Google App Engine
This is Rietveld 408576698