Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1931603002: [polymer] Stops using Polymer subclasses for scalar span unit updates (Closed)

Created:
4 years, 7 months ago by charliea (OOO until 10-5)
Modified:
4 years, 7 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@polymer10-migration
Target Ref:
refs/heads/polymer10-migration
Project:
catapult
Visibility:
Public.

Description

[polymer] Stops using Polymer subclasses for scalar span unit updates Polymer 1.0 makes this near impossible to do and using normal JS handlers should do the trick. NOTRY=true NOPRESUBMIT=true BUG=catapult:#2285 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e5c43a3f2f73005aff4ed6670ba3b58a91a79fdd

Patch Set 1 #

Patch Set 2 : Removes event listener when element is detached #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -28 lines) Patch
M tracing/tracing/value/ui/scalar_span.html View 1 2 2 chunks +10 lines, -28 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
charliea (OOO until 10-5)
4 years, 7 months ago (2016-04-27 19:13:57 UTC) #2
eakuefner
lgtm
4 years, 7 months ago (2016-04-27 19:37:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931603002/40001
4 years, 7 months ago (2016-04-27 19:38:51 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 7 months ago (2016-04-27 19:38:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931603002/40001
4 years, 7 months ago (2016-04-27 19:39:12 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 19:39:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698