Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: public/platform/WebIDBKey.h

Issue 19316002: Separate WebIDBKey type into separate header (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/WebIDBKey.h
diff --git a/public/platform/WebIDBKey.h b/public/platform/WebIDBKey.h
index 5cdda3d5bfdc1c14bdda11132250dcfeecdcab8d..215ed9a9174a77cf58dc31705acd2746c2e5bfe7 100644
--- a/public/platform/WebIDBKey.h
+++ b/public/platform/WebIDBKey.h
@@ -27,6 +27,7 @@
#define WebIDBKey_h
#include "WebCommon.h"
+#include "WebIDBKeyType.h"
#include "WebPrivatePtr.h"
#include "WebString.h"
#include "WebVector.h"
@@ -64,6 +65,14 @@ public:
WEBKIT_EXPORT void assignNull();
WEBKIT_EXPORT void reset();
+ WEBKIT_EXPORT WebIDBKeyType keyType() const;
jamesr 2013/07/16 00:57:20 this is an unfortunately stuttery name, but since
+ WEBKIT_EXPORT bool isValid() const;
+ WEBKIT_EXPORT WebVector<WebIDBKey> array() const; // Only valid for ArrayType.
+ WEBKIT_EXPORT WebString string() const; // Only valid for StringType.
+ WEBKIT_EXPORT double date() const; // Only valid for DateType.
+ WEBKIT_EXPORT double number() const; // Only valid for NumberType.
+
+ // DEPRECATED. FIXME: Remove once all callers switch over to WebIDBKeyType / keyType().
enum Type {
InvalidType = 0,
ArrayType,
@@ -73,13 +82,7 @@ public:
NullType,
MinType,
};
-
WEBKIT_EXPORT Type type() const;
- WEBKIT_EXPORT bool isValid() const;
- WEBKIT_EXPORT WebVector<WebIDBKey> array() const; // Only valid for ArrayType.
- WEBKIT_EXPORT WebString string() const; // Only valid for StringType.
- WEBKIT_EXPORT double date() const; // Only valid for DateType.
- WEBKIT_EXPORT double number() const; // Only valid for NumberType.
#if WEBKIT_IMPLEMENTATION
WebIDBKey(const WTF::PassRefPtr<WebCore::IDBKey>&);

Powered by Google App Engine
This is Rietveld 408576698