Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1931583002: Revert of x11: Don't wait on a MapNotify on override-redirect windows. (Closed)

Created:
4 years, 7 months ago by Elliot Glaysher
Modified:
4 years, 7 months ago
Reviewers:
danakj, Tom Anderson
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of x11: Don't wait on a MapNotify on override-redirect windows. (patchset #3 id:40001 of https://codereview.chromium.org/1896363004/ ) Reason for revert: Patch suspected to cause blank sublist on menus. BUG=606661 Original issue's description: > x11: Don't wait on a MapNotify on override-redirect windows. > > Some window managers do not send MapNotify on override-redirect > windows. Enlightenment doesn't send one, XFCE does, and I don't know > which behaviour is more common. > > This makes mapping resilient against whether we would have received a > MapNotify message on override-redirect window. On override-redirect > windows, we immediately trigger the code that would run in the future > MapNotify handler, and ignore it in the future MapNotify message if it > is already run. > > BUG=381732 > > Committed: https://crrev.com/28bb70402ddc4e68963f536388730c63598f8d65 > Cr-Commit-Position: refs/heads/master@{#389572} TBR=danakj@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=381732 Committed: https://crrev.com/64a7c6401449a843118d9fc208798674a5a8c7ea Cr-Commit-Position: refs/heads/master@{#390140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -57 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 2 chunks +0 lines, -10 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 6 chunks +24 lines, -47 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Elliot Glaysher
Created Revert of x11: Don't wait on a MapNotify on override-redirect windows.
4 years, 7 months ago (2016-04-27 18:14:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931583002/1
4 years, 7 months ago (2016-04-27 18:15:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931583002/1
4 years, 7 months ago (2016-04-27 18:31:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 18:59:55 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:11:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64a7c6401449a843118d9fc208798674a5a8c7ea
Cr-Commit-Position: refs/heads/master@{#390140}

Powered by Google App Engine
This is Rietveld 408576698