Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1931553004: Stop the existing session if it exists before start a new session and add mirroring scenario for cp… (Closed)

Created:
4 years, 7 months ago by Lei Lei
Modified:
4 years, 7 months ago
Reviewers:
imcheng, apacible
CC:
chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop the existing session if it exists before start a new session and add mirroring scenario for cpu and memory usage performance tests. BUG=594225 Committed: https://crrev.com/e7b35db102278bd8d81763a33cd3ae9646abb8ea Cr-Commit-Position: refs/heads/master@{#390687}

Patch Set 1 #

Patch Set 2 : Update media_router_perf_pages.py #

Total comments: 6

Patch Set 3 : Addressed Derek's and Jennifer's comments #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -9 lines) Patch
M chrome/test/media_router/media_router_perf_tests.isolate View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py View 1 2 3 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_perf_pages.py View 1 2 3 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Lei Lei
4 years, 7 months ago (2016-04-28 01:17:46 UTC) #2
imcheng
lgtm https://codereview.chromium.org/1931553004/diff/20001/chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py File chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py (right): https://codereview.chromium.org/1931553004/diff/20001/chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py#newcode81 chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py:81: logging.info('Is there existing router? ' + str(route)) s/router/route
4 years, 7 months ago (2016-04-28 18:28:36 UTC) #3
apacible
lgtm https://codereview.chromium.org/1931553004/diff/20001/chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py File chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py (right): https://codereview.chromium.org/1931553004/diff/20001/chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py#newcode69 chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py:69: " console.info('sink id: ' + sinks[i].id); " Do ...
4 years, 7 months ago (2016-04-28 20:39:56 UTC) #4
Lei Lei
https://codereview.chromium.org/1931553004/diff/20001/chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py File chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py (right): https://codereview.chromium.org/1931553004/diff/20001/chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py#newcode69 chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py:69: " console.info('sink id: ' + sinks[i].id); " On 2016/04/28 ...
4 years, 7 months ago (2016-04-28 23:11:06 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931553004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931553004/40001
4 years, 7 months ago (2016-04-28 23:11:29 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 00:25:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931553004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931553004/40001
4 years, 7 months ago (2016-04-29 17:34:11 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-29 17:39:08 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:26:52 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e7b35db102278bd8d81763a33cd3ae9646abb8ea
Cr-Commit-Position: refs/heads/master@{#390687}

Powered by Google App Engine
This is Rietveld 408576698