third_party/WebKit/Source/core/dom/CharacterData.cpp - Issue 1931513003: Invalidate the previous caret location when editing text nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/CharacterData.cpp

Issue 1931513003: Invalidate the previous caret location when editing text nodes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-before-text-node-update.html ('k') | third_party/WebKit/Source/core/dom/Document.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/CharacterData.cpp

diff --git a/third_party/WebKit/Source/core/dom/CharacterData.cpp b/third_party/WebKit/Source/core/dom/CharacterData.cpp

index a9ab5e34caaa358c846824a725e62aa88bc512f9..28890a0510e1d78ed67dd5923b93e0f21a1db75b 100644

--- a/third_party/WebKit/Source/core/dom/CharacterData.cpp

+++ b/third_party/WebKit/Source/core/dom/CharacterData.cpp

@@ -46,6 +46,8 @@ void CharacterData::setData(const String& data)

if (m_data == nonNullData)

return;

+ document().dataWillChange(*this);

unsigned oldLength = length();

setDataAndUpdate(nonNullData, 0, oldLength, nonNullData.length(), UpdateFromNonParser);

@@ -159,6 +161,9 @@ void CharacterData::setNodeValue(const String& nodeValue)

void CharacterData::setDataAndUpdate(const String& newData, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, UpdateSource source, RecalcStyleBehavior recalcStyleBehavior)

{

+ if (source != UpdateFromParser)

+ document().dataWillChange(*this);

String oldData = m_data;

m_data = newData;