third_party/WebKit/Source/core/dom/Document.h - Issue 1931513003: Invalidate the previous caret location when editing text nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 1931513003: Invalidate the previous caret location when editing text nodes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-before-text-node-update-expected.txt ('K') | « third_party/WebKit/Source/core/dom/CharacterData.cpp ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Document.h

diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h

index fd862518bb85da378c6eb1473ae0affad2dcde12..1169ef751a71e538909bc016580623453b9a0243 100644

--- a/third_party/WebKit/Source/core/dom/Document.h

+++ b/third_party/WebKit/Source/core/dom/Document.h

@@ -77,6 +77,7 @@ class CancellableTaskFactory;

class CanvasFontCache;

class CanvasRenderingContext2D;

class CanvasRenderingContext2DOrWebGLRenderingContext;

+class CharacterData;

class ChromeClient;

class CompositorPendingAnimations;

class Comment;

@@ -640,6 +641,8 @@ public:

void nodeChildrenWillBeRemoved(ContainerNode&);

// nodeWillBeRemoved is only safe when removing one node at a time.

void nodeWillBeRemoved(Node&);

+ // Called just before a destructive update to some CharacterData.

+ void dataWillChange(const CharacterData&);

bool canAcceptChild(const Node& newChild, const Node* oldChild, ExceptionState&) const;

void didInsertText(Node*, unsigned offset, unsigned length);