Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 1931513003: Invalidate the previous caret location when editing text nodes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 bool isRange() const { return selection().isRange(); } 170 bool isRange() const { return selection().isRange(); }
171 bool isCaretOrRange() const { return selection().isCaretOrRange(); } 171 bool isCaretOrRange() const { return selection().isCaretOrRange(); }
172 bool isInPasswordField() const; 172 bool isInPasswordField() const;
173 bool isDirectional() const { return selection().isDirectional(); } 173 bool isDirectional() const { return selection().isDirectional(); }
174 174
175 // If this FrameSelection has a logical range which is still valid, this fun ction return its clone. Otherwise, 175 // If this FrameSelection has a logical range which is still valid, this fun ction return its clone. Otherwise,
176 // the return value from underlying VisibleSelection's firstRange() is retur ned. 176 // the return value from underlying VisibleSelection's firstRange() is retur ned.
177 Range* firstRange() const; 177 Range* firstRange() const;
178 178
179 void nodeWillBeRemoved(Node&); 179 void nodeWillBeRemoved(Node&);
180 void dataWillChange(const CharacterData& node);
180 void didUpdateCharacterData(CharacterData*, unsigned offset, unsigned oldLen gth, unsigned newLength); 181 void didUpdateCharacterData(CharacterData*, unsigned offset, unsigned oldLen gth, unsigned newLength);
181 void didMergeTextNodes(const Text& oldNode, unsigned offset); 182 void didMergeTextNodes(const Text& oldNode, unsigned offset);
182 void didSplitTextNode(const Text& oldNode); 183 void didSplitTextNode(const Text& oldNode);
183 184
184 bool isAppearanceDirty() const; 185 bool isAppearanceDirty() const;
185 void commitAppearanceIfNeeded(LayoutView&); 186 void commitAppearanceIfNeeded(LayoutView&);
186 void updateAppearance(); 187 void updateAppearance();
187 void setCaretVisible(bool caretIsVisible); 188 void setCaretVisible(bool caretIsVisible);
188 bool isCaretBoundsDirty() const { return m_caretRectDirty; } 189 bool isCaretBoundsDirty() const { return m_caretRectDirty; }
189 void setCaretRectNeedsUpdate(); 190 void setCaretRectNeedsUpdate();
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 } 340 }
340 } // namespace blink 341 } // namespace blink
341 342
342 #ifndef NDEBUG 343 #ifndef NDEBUG
343 // Outside the WebCore namespace for ease of invocation from gdb. 344 // Outside the WebCore namespace for ease of invocation from gdb.
344 void showTree(const blink::FrameSelection&); 345 void showTree(const blink::FrameSelection&);
345 void showTree(const blink::FrameSelection*); 346 void showTree(const blink::FrameSelection*);
346 #endif 347 #endif
347 348
348 #endif // FrameSelection_h 349 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698