Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1931503003: Shuffle around WebUI OWNERS (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
CC:
arv+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shuffle around WebUI OWNERS Mark estade@ as emeritus Add dpapad@ and michaelpg@ Move achuith@ to login/signin-related stuff only R=estade@chromium.org,michaelpg@chromium.org,dpapad@chromium.org,achuith@chromium.org BUG=letting us touch the code Committed: https://crrev.com/b8fc1c412e1170ec5d5350c2c12683e7dd8bcc30 Cr-Commit-Position: refs/heads/master@{#390290}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M chrome/browser/resources/OWNERS View 1 chunk +6 lines, -2 lines 0 comments Download
A + chrome/browser/resources/inline_login/OWNERS View 1 chunk +0 lines, -1 line 1 comment Download
M chrome/browser/ui/webui/OWNERS View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/OWNERS View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Dan Beam
4 years, 7 months ago (2016-04-27 23:33:38 UTC) #1
dpapad
lgtm
4 years, 7 months ago (2016-04-27 23:37:14 UTC) #2
michaelpg
lgtm lol @ "emertius" (cl description)
4 years, 7 months ago (2016-04-28 01:49:08 UTC) #3
Dan Beam
On 2016/04/28 01:49:08, michaelpg wrote: > lgtm > > lol @ "emertius" (cl description) Fixed.
4 years, 7 months ago (2016-04-28 01:50:09 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931503003/1
4 years, 7 months ago (2016-04-28 02:51:18 UTC) #7
achuithb
lgtm https://codereview.chromium.org/1931503003/diff/1/chrome/browser/resources/inline_login/OWNERS File chrome/browser/resources/inline_login/OWNERS (right): https://codereview.chromium.org/1931503003/diff/1/chrome/browser/resources/inline_login/OWNERS#newcode1 chrome/browser/resources/inline_login/OWNERS:1: achuith@chromium.org Please add rogerta@
4 years, 7 months ago (2016-04-28 02:54:29 UTC) #8
Evan Stade
lgtm
4 years, 7 months ago (2016-04-28 03:12:11 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 03:28:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931503003/1
4 years, 7 months ago (2016-04-28 03:38:04 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 03:42:05 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:15:57 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b8fc1c412e1170ec5d5350c2c12683e7dd8bcc30
Cr-Commit-Position: refs/heads/master@{#390290}

Powered by Google App Engine
This is Rietveld 408576698