chrome/browser/lifetime/keep_alive_registry.cc - Issue 1931503002: Add BackgroundModeOptimizer that can restart the browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/keep_alive_registry.cc

Issue 1931503002: Add BackgroundModeOptimizer that can restart the browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PushKeepAlive

Patch Set: address comments. disable feature by default Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/lifetime/browser_close_manager.cc ('k') | chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/lifetime/keep_alive_registry.cc

diff --git a/chrome/browser/lifetime/keep_alive_registry.cc b/chrome/browser/lifetime/keep_alive_registry.cc

index f1ed172b2c92f9140e40bc6ce28864e7dfe12da1..77c3ae3b4aaf2a337945b862a264977e709909b3 100644

--- a/chrome/browser/lifetime/keep_alive_registry.cc

+++ b/chrome/browser/lifetime/keep_alive_registry.cc

@@ -92,12 +92,14 @@ void KeepAliveRegistry::Unregister(KeepAliveOrigin origin,

bool new_keeping_alive = IsKeepingAlive();

bool new_restart_allowed = IsRestartAllowed();

- if (new_restart_allowed != old_restart_allowed)

- OnRestartAllowedChanged(new_restart_allowed);

+ // Update the KeepAlive state first, so that listeners can check if we are

+ // trying to shutdown.

if (new_keeping_alive != old_keeping_alive)

OnKeepAliveStateChanged(new_keeping_alive);

+ if (new_restart_allowed != old_restart_allowed)

+ OnRestartAllowedChanged(new_restart_allowed);

DVLOG(1) << "New state of the KeepAliveRegistry:" << *this;

}