Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2365)

Unified Diff: chrome/browser/background/background_mode_optimizer.cc

Issue 1931503002: Add BackgroundModeOptimizer that can restart the browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PushKeepAlive
Patch Set: address comments. disable feature by default Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_mode_optimizer.cc
diff --git a/chrome/browser/background/background_mode_optimizer.cc b/chrome/browser/background/background_mode_optimizer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e3bbae85418fb1808cbcbdbef1aa09e354e45039
--- /dev/null
+++ b/chrome/browser/background/background_mode_optimizer.cc
@@ -0,0 +1,89 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/background/background_mode_optimizer.h"
+
+#include "base/command_line.h"
+#include "base/feature_list.h"
+#include "base/memory/ptr_util.h"
+#include "chrome/browser/background/background_mode_manager.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/browser_shutdown.h"
+#include "chrome/browser/lifetime/application_lifetime.h"
+#include "chrome/browser/lifetime/keep_alive_registry.h"
+#include "chrome/browser/ui/browser_list.h"
+#include "chrome/common/chrome_features.h"
+#include "chrome/common/chrome_switches.h"
+
+BackgroundModeOptimizer::~BackgroundModeOptimizer() {
+ KeepAliveRegistry::GetInstance()->RemoveObserver(this);
+ BrowserList::RemoveObserver(this);
+}
+
+// static
+std::unique_ptr<BackgroundModeOptimizer> BackgroundModeOptimizer::Create() {
+ // If the -keep-alive-for-test flag is passed, then always keep chrome running
+ // in the background until the user explicitly terminates it.
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kKeepAliveForTest))
+ return nullptr;
+
+#if defined(OS_WIN) || defined(OS_LINUX)
+ if (base::FeatureList::IsEnabled(features::kBackgroundModeAllowRestart))
+ return base::WrapUnique(new BackgroundModeOptimizer());
+#endif // defined(OS_WIN) || defined(OS_LINUX)
+
+ return nullptr;
+}
+
+///////////////////////////////////////////////////////////////////////////////
+// KeepAliveRegistry implementation
+
+void BackgroundModeOptimizer::OnKeepAliveStateChanged(bool is_keeping_alive) {
+ // Nothing to do
+}
+
+void BackgroundModeOptimizer::OnKeepAliveRestartStateChanged(bool can_restart) {
+ if (can_restart)
+ TryBrowserRestart();
+}
+///////////////////////////////////////////////////////////////////////////////
+// BrowserListObserver implementation
+
+void BackgroundModeOptimizer::OnBrowserAdded(Browser* browser) {
+ browser_was_added_ = true;
+}
+
+///////////////////////////////////////////////////////////////////////////////
+// private methods
+
+BackgroundModeOptimizer::BackgroundModeOptimizer() : browser_was_added_(false) {
+ KeepAliveRegistry::GetInstance()->AddObserver(this);
+ BrowserList::AddObserver(this);
+}
+
+void BackgroundModeOptimizer::TryBrowserRestart() {
+ // Avoid unecessary restarts. Whether a browser window has been shown is
+ // our current heuristic to determine if it's worth it.
+ if (!browser_was_added_) {
+ DVLOG(1) << "TryBrowserRestart: Cancelled because no browser was added "
+ << "since the last restart";
+ return;
+ }
+
+ // If the application is already shutting down, do not turn it into a restart.
+ if (browser_shutdown::IsTryingToQuit() ||
+ browser_shutdown::GetShutdownType() != browser_shutdown::NOT_VALID) {
+ DVLOG(1) << "TryBrowserRestart: Cancelled because we are shutting down.";
+ return;
+ }
+
+ DVLOG(1) << "TryBrowserRestart: Restarting.";
+ DoRestart();
+}
+
+void BackgroundModeOptimizer::DoRestart() {
+ BackgroundModeManager::set_should_restart_in_background(true);
+ chrome::AttemptRestart();
+}
« no previous file with comments | « chrome/browser/background/background_mode_optimizer.h ('k') | chrome/browser/background/background_mode_optimizer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698