Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5165)

Unified Diff: chrome/browser/background/background_mode_manager_unittest.cc

Issue 1931503002: Add BackgroundModeOptimizer that can restart the browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PushKeepAlive
Patch Set: address comments. disable feature by default Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_mode_manager_unittest.cc
diff --git a/chrome/browser/background/background_mode_manager_unittest.cc b/chrome/browser/background/background_mode_manager_unittest.cc
index ab892378bd05139c3e4cb87c507318306583dee0..6da58ea0297cc791a5bba4c131e1650d02ea114c 100644
--- a/chrome/browser/background/background_mode_manager_unittest.cc
+++ b/chrome/browser/background/background_mode_manager_unittest.cc
@@ -261,12 +261,14 @@ class BackgroundModeManagerWithExtensionsTest : public testing::Test {
// We're getting ready to shutdown the message loop. Clear everything out!
base::RunLoop().RunUntilIdle();
- test_keep_alive_.reset();
-
// TestBackgroundModeManager has dependencies on the infrastructure.
// It should get cleared first.
manager_.reset();
+ // Now that the background manager is destroyed, the test KeepAlive can be
+ // cleared without having |manager_| attempt to perform optimizations.
+ test_keep_alive_.reset();
+
// The Profile Manager references the Browser Process.
// The Browser Process references the Notification UI Manager.
// The Notification UI Manager references the Message Center.
« no previous file with comments | « chrome/browser/background/background_mode_manager.cc ('k') | chrome/browser/background/background_mode_optimizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698