Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19315005: Introduce toHTMLCanvasElement (Closed)

Created:
7 years, 5 months ago by kangil_
Modified:
7 years, 5 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce toHTMLCanvasElement To avoid direct use of static_cast, this patch introduces toHTMLCanvasElement for code cleanup. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M Source/core/html/HTMLCanvasElement.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderHTMLCanvas.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerBacking.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
kangil_
review please? :)
7 years, 5 months ago (2013-07-16 01:15:16 UTC) #1
haraken
LGTM
7 years, 5 months ago (2013-07-16 01:16:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19315005/1
7 years, 5 months ago (2013-07-16 01:18:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19315005/1
7 years, 5 months ago (2013-07-16 05:26:35 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=12849
7 years, 5 months ago (2013-07-16 07:30:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19315005/1
7 years, 5 months ago (2013-07-16 07:33:35 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=12868
7 years, 5 months ago (2013-07-16 08:49:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19315005/1
7 years, 5 months ago (2013-07-16 09:59:54 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=12892
7 years, 5 months ago (2013-07-16 11:01:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19315005/1
7 years, 5 months ago (2013-07-16 11:08:34 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=12918
7 years, 5 months ago (2013-07-16 12:21:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19315005/1
7 years, 5 months ago (2013-07-16 13:24:41 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=17025
7 years, 5 months ago (2013-07-16 14:19:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19315005/1
7 years, 5 months ago (2013-07-16 14:26:33 UTC) #14
commit-bot: I haz the power
7 years, 5 months ago (2013-07-16 15:24:38 UTC) #15
Message was sent while issue was closed. 
Change committed as 154293

Powered by Google App Engine
This is Rietveld 408576698