Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1931433002: Revert of [debugger] unskip mjsunit/debug-stepin-builtin-callback-opt. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] unskip mjsunit/debug-stepin-builtin-callback-opt. (patchset #1 id:1 of https://codereview.chromium.org/1927543002/ ) Reason for revert: Now we do have a repro! https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3187/steps/Mjsunit%20-%20ignition%20-%20turbofan/logs/debug-stepin-builtin-.. Original issue's description: > [debugger] unskip mjsunit/debug-stepin-builtin-callback-opt. > > This test does not seem to fail any longer. > > R=machenbach@chromium.org > BUG=v8:4690 > LOG=N > > Committed: https://crrev.com/f8e44fb5aaaa80cf2d39bc3164f2c962a6b57f5e > Cr-Commit-Position: refs/heads/master@{#35814} TBR=machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4690 Committed: https://crrev.com/612985b298c8d5a150b36ba7b07e9b5cad7bb729 Cr-Commit-Position: refs/heads/master@{#35815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
Created Revert of [debugger] unskip mjsunit/debug-stepin-builtin-callback-opt.
4 years, 7 months ago (2016-04-27 10:53:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931433002/1
4 years, 7 months ago (2016-04-27 10:53:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 10:53:25 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/612985b298c8d5a150b36ba7b07e9b5cad7bb729 Cr-Commit-Position: refs/heads/master@{#35815}
4 years, 7 months ago (2016-04-27 10:55:02 UTC) #6
Michael Achenbach
4 years, 7 months ago (2016-04-27 11:37:08 UTC) #7
Message was sent while issue was closed.
lgtm - good to have a repro!

Powered by Google App Engine
This is Rietveld 408576698