Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1931403002: Make it an error if there's more than one build rule for a single output. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Make it an error if there's more than one build rule for a single output. This warning seems to not fire anywhere at the moment. Make it an error to make sure it stays that way. If this breaks your bot, please a) revert b) let me know. The build error will look like "multiple rules generate X [-w dupbuild=err]". BUG=505679, 581547 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M scripts/slave/compile.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
weee (looks like 1.7.1 is gonna stick, and we'll just roll forward for output tweaks, ...
4 years, 7 months ago (2016-04-29 16:50:05 UTC) #2
scottmg
lgtm
4 years, 7 months ago (2016-04-29 16:59:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931403002/1
4 years, 7 months ago (2016-04-29 18:57:14 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 19:02:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300364

Powered by Google App Engine
This is Rietveld 408576698