third_party/WebKit/Source/platform/testing/FontTestHelpers.cpp - Issue 1931393002: Introduce typeface cache in blink::FontCache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/testing/FontTestHelpers.cpp

Issue 1931393002: Introduce typeface cache in blink::FontCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wip: others Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/testing/FontTestHelpers.cpp

diff --git a/third_party/WebKit/Source/platform/testing/FontTestHelpers.cpp b/third_party/WebKit/Source/platform/testing/FontTestHelpers.cpp

index 6ac93d063d6e1458346631fa6332cedadf049b69..45d3f38f949d8b3c0d326a0696afe1215a927926 100644

--- a/third_party/WebKit/Source/platform/testing/FontTestHelpers.cpp

+++ b/third_party/WebKit/Source/platform/testing/FontTestHelpers.cpp

@@ -34,11 +34,10 @@ public:

const AtomicString& familyName) override

{

FontPlatformData platformData = m_customPlatformData->fontPlatformData(

- fontDescription.effectiveFontSize(),

fontDescription.isSyntheticBold(),

fontDescription.isSyntheticItalic(),

fontDescription.orientation());

- return SimpleFontData::create(platformData, CustomFontData::create());

+ return SimpleFontData::create(platformData, fontDescription.effectiveFontSize(), CustomFontData::create());

}

void willUseFontData(const FontDescription&, const AtomicString& familyName,