third_party/WebKit/Source/platform/fonts/FontPlatformDataTest.cpp - Issue 1931393002: Introduce typeface cache in blink::FontCache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/FontPlatformDataTest.cpp

Issue 1931393002: Introduce typeface cache in blink::FontCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wip: others Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/FontPlatformDataTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/FontPlatformDataTest.cpp b/third_party/WebKit/Source/platform/fonts/FontPlatformDataTest.cpp

index cb57226a4fd068541b19eca5a45469d7e5b04b5e..31e832c4a9aa3087d6d06155015f78cad40062e8 100644

--- a/third_party/WebKit/Source/platform/fonts/FontPlatformDataTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/FontPlatformDataTest.cpp

@@ -52,7 +52,7 @@ TEST(FontPlatformDataTest, AhemHasNoSpaceInLigaturesOrKerning)

const FontPlatformData& platformData = font.primaryFont()->platformData();

TypesettingFeatures features = Kerning | Ligatures;

- EXPECT_FALSE(platformData.hasSpaceInLigaturesOrKerning(features));

+ EXPECT_FALSE(platformData.hasSpaceInLigaturesOrKerning(font.primaryFont()->size(), font.primaryFont()->style(), features));

}

TEST(FontPlatformDataTest, AhemSpaceLigatureHasSpaceInLigaturesOrKerning)

@@ -61,7 +61,7 @@ TEST(FontPlatformDataTest, AhemSpaceLigatureHasSpaceInLigaturesOrKerning)

const FontPlatformData& platformData = font.primaryFont()->platformData();

TypesettingFeatures features = Kerning | Ligatures;

- EXPECT_TRUE(platformData.hasSpaceInLigaturesOrKerning(features));

+ EXPECT_TRUE(platformData.hasSpaceInLigaturesOrKerning(font.primaryFont()->size(), font.primaryFont()->style(), features));

}

TEST(FontPlatformDataTest, AhemSpaceLigatureHasNoSpaceWithoutFontFeatures)

@@ -70,7 +70,7 @@ TEST(FontPlatformDataTest, AhemSpaceLigatureHasNoSpaceWithoutFontFeatures)

const FontPlatformData& platformData = font.primaryFont()->platformData();

TypesettingFeatures features = 0;

- EXPECT_FALSE(platformData.hasSpaceInLigaturesOrKerning(features));

+ EXPECT_FALSE(platformData.hasSpaceInLigaturesOrKerning(font.primaryFont()->size(), font.primaryFont()->style(), features));

}

} // namespace blink