third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp - Issue 1931393002: Introduce typeface cache in blink::FontCache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp

Issue 1931393002: Introduce typeface cache in blink::FontCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wip: others Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.h ('k') | third_party/WebKit/Source/platform/fonts/FontDataCache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp b/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp

index 714fc0496bd0077427bdbb4cbcc42412526b51fa..a9aefe36b15bf6e972991ccb49af3949246781a7 100644

--- a/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp

+++ b/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp

@@ -50,10 +50,10 @@ FontCustomPlatformData::~FontCustomPlatformData()

{

}

-FontPlatformData FontCustomPlatformData::fontPlatformData(float size, bool bold, bool italic, FontOrientation orientation)

+FontPlatformData FontCustomPlatformData::fontPlatformData(bool bold, bool italic, FontOrientation orientation)

{

ASSERT(m_typeface);

- return FontPlatformData(m_typeface.get(), "", size, bold && !m_typeface->isBold(), italic && !m_typeface->isItalic(), orientation);

+ return FontPlatformData(m_typeface.get(), "", bold && !m_typeface->isBold(), italic && !m_typeface->isItalic(), orientation);

}

PassOwnPtr<FontCustomPlatformData> FontCustomPlatformData::create(SharedBuffer* buffer, String& otsParseMessage)