third_party/WebKit/Source/platform/fonts/FontCache.cpp - Issue 1931393002: Introduce typeface cache in blink::FontCache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/FontCache.cpp

Issue 1931393002: Introduce typeface cache in blink::FontCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wip: others Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/FontCache.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/FontCache.cpp b/third_party/WebKit/Source/platform/fonts/FontCache.cpp

index 29b184198ae71ce804bb47a3fdb79ec82ced6062..0aa6afb2bf15e94f75ba92e17f8eca133f552a97 100644

--- a/third_party/WebKit/Source/platform/fonts/FontCache.cpp

+++ b/third_party/WebKit/Source/platform/fonts/FontCache.cpp

@@ -104,7 +104,7 @@ FontPlatformData* FontCache::getFontPlatformData(const FontDescription& fontDesc

// to avoid trigering its dtor hash-changed asserts.

auto addResult = gFontPlatformDataCache->add(key, nullptr);

if (addResult.isNewEntry)

- addResult.storedValue->value = createFontPlatformData(fontDescription, creationParams, fontDescription.effectiveFontSize());

+ addResult.storedValue->value = createFontPlatformData(fontDescription, creationParams);

result = addResult.storedValue->value.get();

foundResult = result || !addResult.isNewEntry;