third_party/WebKit/Source/core/fetch/FontResource.cpp - Issue 1931393002: Introduce typeface cache in blink::FontCache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/FontResource.cpp

Issue 1931393002: Introduce typeface cache in blink::FontCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wip: others Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/FontResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/FontResource.cpp b/third_party/WebKit/Source/core/fetch/FontResource.cpp

index 72f28729bbe1c0cae5b0b59d8b7ce7b2c68fa672..efc0bae75b0f832be3a7cfa72d3da945fa36b49d 100644

--- a/third_party/WebKit/Source/core/fetch/FontResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/FontResource.cpp

@@ -134,10 +134,10 @@ bool FontResource::ensureCustomFontData()

return m_fontData.get();

}

-FontPlatformData FontResource::platformDataFromCustomData(float size, bool bold, bool italic, FontOrientation orientation)

+FontPlatformData FontResource::platformDataFromCustomData(bool bold, bool italic, FontOrientation orientation)

{

ASSERT(m_fontData);

- return m_fontData->fontPlatformData(size, bold, italic, orientation);

+ return m_fontData->fontPlatformData(bold, italic, orientation);

}

bool FontResource::isSafeToUnlock() const