Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1378)

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

Issue 1931303002: Simplify SVG layout attribute reordering (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove ASSERT. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
index 18e37831e5e76d6fcce75e04d7bcb52fd593fcd8..1fbc2b47065ef89514501a0336e596e0ff869211 100644
--- a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
+++ b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
@@ -1279,12 +1279,10 @@ void InlineFlowBox::collectLeafBoxesInLogicalOrder(Vector<InlineBox*>& leafBoxes
++it;
}
Vector<InlineBox*>::iterator last = it;
- if (customReverseImplementation) {
- ASSERT(userData);
+ if (customReverseImplementation)
(*customReverseImplementation)(userData, first, last);
Stephen Chennney 2016/04/29 18:05:19 Do we document the fact that userData may be null
fs 2016/04/29 18:44:15 It's dead AFAIK. reorderValueLists is the only thi
- } else {
+ else
std::reverse(first, last);
- }
}
++minLevel;
}

Powered by Google App Engine
This is Rietveld 408576698