Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1931293005:
[tools] added wasm to the list of benchmarks (Closed)
|
Created:
4 years, 7 months ago by Mircea Trofin Modified:
4 years, 7 months ago CC:
v8-reviews_googlegroups.com, Clemens Hammacher Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[tools] added wasm to the list of benchmarks
BUG=
Committed: https://crrev.com/c6405c4a60a7846938bebff621932dfb52fe0d3f
Cr-Commit-Position: refs/heads/master@{#36055}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== [tools] added wasm to the list of benchmarks BUG= ========== to ========== [tools] added wasm to the list of benchmarks BUG= ==========
mtrofin@chromium.org changed reviewers: + clemensh@chromium.org
lgtm
The CQ bit was checked by mtrofin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931293005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931293005/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
Message was sent while issue was closed.
mtrofin@chromium.org changed reviewers: + machenbach@chromium.org
Message was sent while issue was closed.
Message was sent while issue was closed.
lgtm for resubmission
The CQ bit was checked by mtrofin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931293005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931293005/1
Message was sent while issue was closed.
Description was changed from ========== [tools] added wasm to the list of benchmarks BUG= ========== to ========== [tools] added wasm to the list of benchmarks BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [tools] added wasm to the list of benchmarks BUG= ========== to ========== [tools] added wasm to the list of benchmarks BUG= Committed: https://crrev.com/c6405c4a60a7846938bebff621932dfb52fe0d3f Cr-Commit-Position: refs/heads/master@{#36055} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c6405c4a60a7846938bebff621932dfb52fe0d3f Cr-Commit-Position: refs/heads/master@{#36055} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
