Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1931253004: Determine routing ID before potentially invalidating the frame (Closed)

Created:
4 years, 7 months ago by robwu
Modified:
4 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Determine routing ID before potentially invalidating the frame BUG=608156 Committed: https://crrev.com/02aac0ffcff2e9830e0c9e0bdcc34b45fb666fcf Cr-Commit-Position: refs/heads/master@{#390971}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M extensions/renderer/messaging_bindings.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
robwu
4 years, 7 months ago (2016-04-30 11:33:05 UTC) #2
Devlin
lgtm https://codereview.chromium.org/1931253004/diff/1/extensions/renderer/messaging_bindings.cc File extensions/renderer/messaging_bindings.cc (right): https://codereview.chromium.org/1931253004/diff/1/extensions/renderer/messaging_bindings.cc#newcode459 extensions/renderer/messaging_bindings.cc:459: channel_name, &source, info, tls_channel_id, &port_created)); Let's add a ...
4 years, 7 months ago (2016-05-02 13:57:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931253004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931253004/20001
4 years, 7 months ago (2016-05-02 15:22:24 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 17:07:59 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 17:09:15 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/02aac0ffcff2e9830e0c9e0bdcc34b45fb666fcf
Cr-Commit-Position: refs/heads/master@{#390971}

Powered by Google App Engine
This is Rietveld 408576698