Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1931143002: Triaging some of the remaining site-per-process layout test failures. (Closed)

Created:
4 years, 7 months ago by Łukasz Anforowicz
Modified:
4 years, 7 months ago
Reviewers:
alexmos
CC:
chromium-reviews, blink-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@do-not-dump-frame-callbacks
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Triaging some of the remaining site-per-process layout test failures. Most of the changes in this CL just moved test expectations around and added comments with bug pointers. One exception is that http/tests/appcache/remove-cache.html expectation has been removed altogether: - this test passes on the Site Isolation FYI - flakiness is already called out in https://crbug.com/518929 - locally I see a failure with and without --site-per-process, but since the bots are happy we should just remove the exception I think BUG=582211, 608015, 608023, 606594, 607991, 607981 Committed: https://crrev.com/6bd0f3201a2bc6c1d30dfc8a5a23eeeaedf56e2b Cr-Commit-Position: refs/heads/master@{#391262}

Patch Set 1 #

Patch Set 2 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 4 chunks +21 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
Łukasz Anforowicz
Alex, PTAL?
4 years, 7 months ago (2016-04-29 21:42:58 UTC) #4
alexmos
LGTM
4 years, 7 months ago (2016-04-29 23:11:47 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931143002/20001
4 years, 7 months ago (2016-05-03 15:06:37 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 16:13:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931143002/20001
4 years, 7 months ago (2016-05-03 16:17:29 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 16:26:24 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 16:29:21 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6bd0f3201a2bc6c1d30dfc8a5a23eeeaedf56e2b
Cr-Commit-Position: refs/heads/master@{#391262}

Powered by Google App Engine
This is Rietveld 408576698