components/autofill/core/browser/contact_info_unittest.cc - Issue 1931123002: [Autofill] Make PersonalDataManager::OverwriteWith case sensitive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/contact_info_unittest.cc

Issue 1931123002: [Autofill] Make PersonalDataManager::OverwriteWith case sensitive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/contact_info.cc ('k') | components/test/data/autofill/merge/input/addressLinesLessInfo.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/contact_info_unittest.cc

diff --git a/components/autofill/core/browser/contact_info_unittest.cc b/components/autofill/core/browser/contact_info_unittest.cc

index 1330e5387498ecb662e5cc5cde5de8f1480a49c4..c04f148892b3c5011e05f3086e0ed0fafa4e99fc 100644

--- a/components/autofill/core/browser/contact_info_unittest.cc

+++ b/components/autofill/core/browser/contact_info_unittest.cc

@@ -188,22 +188,22 @@ TEST(NameInfoTest, ParsedNamesAreEqual) {

{"Marion", "Mitchell", "Morrison"},

true},

- // Case-insensative comparisons.

+ // Case-sensitive comparisons.

{{"Marion", "Mitchell", "Morrison"},

{"Marion", "Mitchell", "MORRISON"},

- true},

+ false},

{{"Marion", "Mitchell", "Morrison"},

{"MARION", "Mitchell", "MORRISON"},

- true},

+ false},

{{"Marion", "Mitchell", "Morrison"},

{"MARION", "MITCHELL", "MORRISON"},

- true},

+ false},

{{"Marion", "", "Mitchell Morrison"},

{"MARION", "", "MITCHELL MORRISON"},

- true},

+ false},

{{"Marion Mitchell", "", "Morrison"},

{"MARION MITCHELL", "", "MORRISON"},

- true},

+ false},

// Identical full names but different canonical forms.

{{"Marion", "Mitchell", "Morrison"},

@@ -222,7 +222,7 @@ TEST(NameInfoTest, ParsedNamesAreEqual) {

// Non-ASCII characters.

{{"M\xc3\xa1rion Mitchell", "", "Morrison"},

- {"M\xc3\x81RION MITCHELL", "", "MORRISON"},

+ {"M\xc3\xa1rion Mitchell", "", "Morrison"},

true},

};