Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: tracing/tracing/ui/extras/chrome/cc/display_item_list_item.html

Issue 1931103002: [polymer] Uses setAttribute() in DisplayItemListItem.created() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/extras/chrome/cc/display_item_list_item.html
diff --git a/tracing/tracing/ui/extras/chrome/cc/display_item_list_item.html b/tracing/tracing/ui/extras/chrome/cc/display_item_list_item.html
index dea9921b12b83d04eaf384937df60d2bbaecd65b..a493302507955aba745c28bd9ec597cf4b9c0846 100644
--- a/tracing/tracing/ui/extras/chrome/cc/display_item_list_item.html
+++ b/tracing/tracing/ui/extras/chrome/cc/display_item_list_item.html
@@ -89,10 +89,12 @@ An element displaying basic information about a display item in a list view.
is: 'tr-ui-e-chrome-cc-display-item-list-item',
created: function() {
- this.name = '';
- this.rawDetails = '';
- this.richDetails = undefined;
- this.data_ = undefined;
+ // TODO(charliea): Why is setAttribute necessary here but not below? We
+ // should reach out to the Polymer team to figure out.
+ this.setAttribute('name', '');
+ this.setAttribute('rawDetails', '');
+ this.setAttribute('richDetails', undefined);
+ this.setAttribute('data_', undefined);
},
get data() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698