Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1931033002:
Flip all but one of the Linux Desktop ChromeOS CQ builders to GN. (Closed)
|
Created:
4 years, 7 months ago by Dirk Pranke Modified:
4 years, 6 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip all but one of the Linux Desktop ChromeOS CQ builders to GN.
(i.e.,chromeos=1, non-simplechrome, non-chroot).
R=stevenjb@chromium.org
TBR=brettw@chromium.org
BUG=433082
Committed: https://crrev.com/34dabb7fba853e6bffd1b380c71f9571fc28c08b
Cr-Commit-Position: refs/heads/master@{#400604}
Patch Set 1 #Patch Set 2 : merge forward #Patch Set 3 : merge #Patch Set 4 : merge, leave CQ alone #Patch Set 5 : fix rpath for minigbm #Patch Set 6 : propagate rpath config properly #Patch Set 7 : propagate rpath up from minigbm #Patch Set 8 : more fixes #Patch Set 9 : merge #Patch Set 10 : more data_deps for interactive_ui_tests, message_center_unittests, chromeos_unittests #Patch Set 11 : fix keyboard target #Patch Set 12 : fix data for chromeos_unittests #Patch Set 13 : remove references to material paks #Patch Set 14 : make message_center_unittests windowed #Patch Set 15 : merge #Patch Set 16 : merge to r398686 #Patch Set 17 : suppress test failures for now #Patch Set 18 : fix build files #Patch Set 19 : merge to r399284 #Patch Set 20 : rebase on top of disabled tests #Patch Set 21 : rebase #Patch Set 22 : rebase #Patch Set 23 : disable GlobalCommand properly #Patch Set 24 : leave rel_ng on gyp for now #Patch Set 25 : leave ozone on gyp instead #
Messages
Total messages: 46 (19 generated)
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
With this CL and the simplechrome one, all of the cros bots on the chromium.* waterfalls will be on GN.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931033002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931033002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
iannucci@chromium.org changed reviewers: + iannucci@chromium.org
rs lgtm
The CQ bit was checked by dpranke@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931033002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931033002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Flip remaining Linux Desktop ChromeOS bots to GN. This flips all of the remaining Linux desktop ChromeOS (i.e., chromeos=1, non-simplechrome, non-chroot) bots to GN. This also removes linux_chromium_gn_chromeos_rel from the CQ, because it's now redundant. R=stevenjb@chromium.org BUG=433082 ========== to ========== Flip remaining Linux Desktop ChromeOS bots to GN. This flips all of the remaining Linux desktop ChromeOS (i.e., chromeos=1, non-simplechrome, non-chroot) bots to GN. R=stevenjb@chromium.org BUG=433082 ==========
@stevenjb - with this set of changes, we're down to < 20 failures across ~4 test suites. I'm inclined to disable the rest of the tests, file bugs, and flip the bots over, and then either come back to fixing the tests, or find other people to fix the tests. WDYT? (I still have to go back through all of these changes and make sure they're right, though, so we almost certainly don't want to land this as-is).
@stevenjb - you can see the latest set of failures. I think there's ~a dozen or so individual tests failing across browser_tests and unit_tests.
I just took a look at them. Do we know why they started failing? Most of these are crashes. I am a bit reluctant to disable even a handful of tests without at least understanding why they are failing. I will do some investigating today. On Wed, Jun 8, 2016 at 6:02 PM, <dpranke@chromium.org> wrote: > @stevenjb - you can see the latest set of failures. I think there's ~a > dozen or > so individual tests failing across browser_tests and unit_tests. > > https://codereview.chromium.org/1931033002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2016/06/09 17:11:30, stevenjb wrote: > I just took a look at them. Do we know why they started failing? Most of > these are crashes. I am a bit reluctant to disable even a handful of tests > without at least understanding why they are failing. I will do some > investigating today. I don't have any reason to think that they've ever worked in a GN build. Most of the failures I've fixed thus far as just things like missing files in the build, and I'd expect these to be similar. The point of landing the suppressions would be to keep things from getting worse while we continue to work on fixing these. I haven't yet had time to look at these specific failures. I'm also fine w/ not landing these suppressions, but at least having them in the file in the patch gives us a reference for which tests to look at without having to look at the build logs.
Yeah, I would rather just spend a day to see if we can get these fixed. I will see what I can do. On Thu, Jun 9, 2016 at 10:14 AM, <dpranke@chromium.org> wrote: > On 2016/06/09 17:11:30, stevenjb wrote: > > I just took a look at them. Do we know why they started failing? Most of > > these are crashes. I am a bit reluctant to disable even a handful of > tests > > without at least understanding why they are failing. I will do some > > investigating today. > > I don't have any reason to think that they've ever worked in a GN build. > Most of the failures I've fixed thus far as just things like missing files > in > the build, > and I'd expect these to be similar. The point of landing the suppressions > would > be to keep things from getting worse while we continue to work on fixing > these. > > I haven't yet had time to look at these specific failures. > > I'm also fine w/ not landing these suppressions, but at least having them > in > the file in the patch gives us a reference for which tests to look at > without > having to look at the build logs. > > https://codereview.chromium.org/1931033002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Looks like we still have NetworkConfigurationUpdaterTest.PolicyIsValidatedAndRepaired failing on the bots (a unit_test), but that's it. Ozone also has: GlobalCommandsApiTest.GlobalCommand in interactive_ui_tests, GLImageOzoneNativePixmapDrm/GLImageTest/0.CreateAndDestroy GLImageOzoneNativePixmapDrm/GLImageBindTest/0.BindTexImage in gl_unittests, and OutOfProcessPPAPITest.TrueTypeFont OutOfProcessPPAPITest.BrowserFont in content_browsertests. I'll assume that you still want to triage these if possible before we flip anything. I may have time to help w/ this in the next couple days ...
OK, I had a chance to look at all these today: On Sat, Jun 11, 2016 at 5:26 PM, <dpranke@chromium.org> wrote: > Looks like we still have > > NetworkConfigurationUpdaterTest.PolicyIsValidatedAndRepaired > I'm not quite sure but I think this will fix it: https://codereview.chromium.org/2067693002/ (I had to include your patch to test with GN, I'll update the CL tomorrow without that patch) > > failing on the bots (a unit_test), but that's it. > > Ozone also has: > > GlobalCommandsApiTest.GlobalCommand > > in interactive_ui_tests, > > Filed https://bugs.chromium.org/p/chromium/issues/detail?id=619784 GLImageOzoneNativePixmapDrm/GLImageTest/0.CreateAndDestroy > GLImageOzoneNativePixmapDrm/GLImageBindTest/0.BindTexImage > > in gl_unittests, and > > Added a comment to https://bugs.chromium.org/p/chromium/issues/detail?id=618516, Fix is up: https://codereview.chromium.org/2060753004/ OutOfProcessPPAPITest.TrueTypeFont > OutOfProcessPPAPITest.BrowserFont > > in content_browsertests. > Filed https://bugs.chromium.org/p/chromium/issues/detail?id=619765 Once the above two CLs are in, I am OK with disabling the remaining tests with a comment referencing the bugs filed. Cheers, Steven -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2016/06/14 01:14:29, stevenjb wrote: > OK, I had a chance to look at all these today: > > On Sat, Jun 11, 2016 at 5:26 PM, <mailto:dpranke@chromium.org> wrote: > > > Looks like we still have > > > > NetworkConfigurationUpdaterTest.PolicyIsValidatedAndRepaired > > > > I'm not quite sure but I think this will fix it: > https://codereview.chromium.org/2067693002/ > > (I had to include your patch to test with GN, I'll update the CL tomorrow > without that patch) > > > > > > failing on the bots (a unit_test), but that's it. > > > > Ozone also has: > > > > GlobalCommandsApiTest.GlobalCommand > > > > in interactive_ui_tests, > > > > Filed https://bugs.chromium.org/p/chromium/issues/detail?id=619784 > > GLImageOzoneNativePixmapDrm/GLImageTest/0.CreateAndDestroy > > GLImageOzoneNativePixmapDrm/GLImageBindTest/0.BindTexImage > > > > in gl_unittests, and > > > > Added a comment to > https://bugs.chromium.org/p/chromium/issues/detail?id=618516, > Fix is up: https://codereview.chromium.org/2060753004/ > > OutOfProcessPPAPITest.TrueTypeFont > > OutOfProcessPPAPITest.BrowserFont > > > > in content_browsertests. > > > > Filed https://bugs.chromium.org/p/chromium/issues/detail?id=619765 > > Once the above two CLs are in, I am OK with disabling the remaining tests > with a comment referencing the bugs filed. > > Cheers, > Steven > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org. Running tryjobs again to confirm that with the changes in ToT we can disable the remaining tests and flip these!
On 2016/06/15 00:15:54, stevenjb wrote: > On 2016/06/14 01:14:29, stevenjb wrote: > > OK, I had a chance to look at all these today: > > > > On Sat, Jun 11, 2016 at 5:26 PM, <mailto:dpranke@chromium.org> wrote: > > > > > Looks like we still have > > > > > > NetworkConfigurationUpdaterTest.PolicyIsValidatedAndRepaired > > > > > > > I'm not quite sure but I think this will fix it: > > https://codereview.chromium.org/2067693002/ > > > > (I had to include your patch to test with GN, I'll update the CL tomorrow > > without that patch) > > > > > > > > > > failing on the bots (a unit_test), but that's it. > > > > > > Ozone also has: > > > > > > GlobalCommandsApiTest.GlobalCommand > > > > > > in interactive_ui_tests, > > > > > > Filed https://bugs.chromium.org/p/chromium/issues/detail?id=619784 > > > > GLImageOzoneNativePixmapDrm/GLImageTest/0.CreateAndDestroy > > > GLImageOzoneNativePixmapDrm/GLImageBindTest/0.BindTexImage > > > > > > in gl_unittests, and > > > > > > Added a comment to > > https://bugs.chromium.org/p/chromium/issues/detail?id=618516, > > Fix is up: https://codereview.chromium.org/2060753004/ > > > > OutOfProcessPPAPITest.TrueTypeFont > > > OutOfProcessPPAPITest.BrowserFont > > > > > > in content_browsertests. > > > > > > > Filed https://bugs.chromium.org/p/chromium/issues/detail?id=619765 > > > > Once the above two CLs are in, I am OK with disabling the remaining tests > > with a comment referencing the bugs filed. > > > > Cheers, > > Steven > > > > -- > > You received this message because you are subscribed to the Google Groups > > "Chromium-reviews" group. > > To unsubscribe from this group and stop receiving emails from it, send an > email > > to mailto:chromium-reviews+unsubscribe@chromium.org. > > Running tryjobs again to confirm that with the changes in ToT we can disable the > remaining tests and flip these! Hey Dirk. I thin we can disable the following on linux_chromium_chromeos_ozone_rel_ng: content_browsertests: OutOfProcessPPAPITest.TrueTypeFont OutOfProcessPPAPITest.BrowserFont crbug.com/619765 These should no longer run, I'm not sure why they just failed, but we can disable them for now: GLImageOzoneNativePixmapDrm/GLImageTest/0.CreateAndDestroy GLImageOzoneNativePixmapDrm/GLImageBindTest/0.BindTexImage crbug.com/618516 interactive_ui_tests: GlobalCommandsApiTest.GlobalCommand crbug.com/619784 Then we should be good to go!
Okay, I'll post a CL for that. On Wed, Jun 15, 2016 at 4:37 PM, <stevenjb@chromium.org> wrote: > On 2016/06/15 00:15:54, stevenjb wrote: > > On 2016/06/14 01:14:29, stevenjb wrote: > > > OK, I had a chance to look at all these today: > > > > > > On Sat, Jun 11, 2016 at 5:26 PM, <mailto:dpranke@chromium.org> wrote: > > > > > > > Looks like we still have > > > > > > > > NetworkConfigurationUpdaterTest.PolicyIsValidatedAndRepaired > > > > > > > > > > I'm not quite sure but I think this will fix it: > > > https://codereview.chromium.org/2067693002/ > > > > > > (I had to include your patch to test with GN, I'll update the CL > tomorrow > > > without that patch) > > > > > > > > > > > > > > failing on the bots (a unit_test), but that's it. > > > > > > > > Ozone also has: > > > > > > > > GlobalCommandsApiTest.GlobalCommand > > > > > > > > in interactive_ui_tests, > > > > > > > > Filed https://bugs.chromium.org/p/chromium/issues/detail?id=619784 > > > > > > GLImageOzoneNativePixmapDrm/GLImageTest/0.CreateAndDestroy > > > > GLImageOzoneNativePixmapDrm/GLImageBindTest/0.BindTexImage > > > > > > > > in gl_unittests, and > > > > > > > > Added a comment to > > > https://bugs.chromium.org/p/chromium/issues/detail?id=618516, > > > Fix is up: https://codereview.chromium.org/2060753004/ > > > > > > OutOfProcessPPAPITest.TrueTypeFont > > > > OutOfProcessPPAPITest.BrowserFont > > > > > > > > in content_browsertests. > > > > > > > > > > Filed https://bugs.chromium.org/p/chromium/issues/detail?id=619765 > > > > > > Once the above two CLs are in, I am OK with disabling the remaining > tests > > > with a comment referencing the bugs filed. > > > > > > Cheers, > > > Steven > > > > > > -- > > > You received this message because you are subscribed to the Google > Groups > > > "Chromium-reviews" group. > > > To unsubscribe from this group and stop receiving emails from it, send > an > > email > > > to mailto:chromium-reviews+unsubscribe@chromium.org. > > > > Running tryjobs again to confirm that with the changes in ToT we can > disable > the > > remaining tests and flip these! > > Hey Dirk. I thin we can disable the following on > linux_chromium_chromeos_ozone_rel_ng: > > content_browsertests: > OutOfProcessPPAPITest.TrueTypeFont > OutOfProcessPPAPITest.BrowserFont > crbug.com/619765 > > These should no longer run, I'm not sure why they just failed, but we can > disable them for now: > GLImageOzoneNativePixmapDrm/GLImageTest/0.CreateAndDestroy > GLImageOzoneNativePixmapDrm/GLImageBindTest/0.BindTexImage > crbug.com/618516 > > interactive_ui_tests: > GlobalCommandsApiTest.GlobalCommand > crbug.com/619784 > > Then we should be good to go! > > > > https://codereview.chromium.org/1931033002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Description was changed from ========== Flip remaining Linux Desktop ChromeOS bots to GN. This flips all of the remaining Linux desktop ChromeOS (i.e., chromeos=1, non-simplechrome, non-chroot) bots to GN. R=stevenjb@chromium.org BUG=433082 ========== to ========== Flip all but one of the Linux Desktop ChromeOS CQ builders to GN. (i.e.,chromeos=1, non-simplechrome, non-chroot). R=stevenjb@chromium.org BUG=433082 ==========
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931033002/480001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Flip all but one of the Linux Desktop ChromeOS CQ builders to GN. (i.e.,chromeos=1, non-simplechrome, non-chroot). R=stevenjb@chromium.org BUG=433082 ========== to ========== Flip all but one of the Linux Desktop ChromeOS CQ builders to GN. (i.e.,chromeos=1, non-simplechrome, non-chroot). R=stevenjb@chromium.org TBR=brettw@chromium.org BUG=433082 ==========
dpranke@chromium.org changed reviewers: + brettw@chromium.org
The CQ bit was checked by dpranke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org, iannucci@chromium.org Link to the patchset: https://codereview.chromium.org/1931033002/#ps480001 (title: "leave ozone on gyp instead")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931033002/480001
Message was sent while issue was closed.
Description was changed from ========== Flip all but one of the Linux Desktop ChromeOS CQ builders to GN. (i.e.,chromeos=1, non-simplechrome, non-chroot). R=stevenjb@chromium.org TBR=brettw@chromium.org BUG=433082 ========== to ========== Flip all but one of the Linux Desktop ChromeOS CQ builders to GN. (i.e.,chromeos=1, non-simplechrome, non-chroot). R=stevenjb@chromium.org TBR=brettw@chromium.org BUG=433082 ==========
Message was sent while issue was closed.
Committed patchset #25 (id:480001)
Message was sent while issue was closed.
Description was changed from ========== Flip all but one of the Linux Desktop ChromeOS CQ builders to GN. (i.e.,chromeos=1, non-simplechrome, non-chroot). R=stevenjb@chromium.org TBR=brettw@chromium.org BUG=433082 ========== to ========== Flip all but one of the Linux Desktop ChromeOS CQ builders to GN. (i.e.,chromeos=1, non-simplechrome, non-chroot). R=stevenjb@chromium.org TBR=brettw@chromium.org BUG=433082 Committed: https://crrev.com/34dabb7fba853e6bffd1b380c71f9571fc28c08b Cr-Commit-Position: refs/heads/master@{#400604} ==========
Message was sent while issue was closed.
Patchset 25 (id:??) landed as https://crrev.com/34dabb7fba853e6bffd1b380c71f9571fc28c08b Cr-Commit-Position: refs/heads/master@{#400604} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
