Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1931013002: MD-ify textfields and combobox. (Closed)

Created:
4 years, 7 months ago by Evan Stade
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, tfarina, noyau+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD-ify textfields and combobox. The combobox dropdown itself needs some work on alignment. I'm not yet sure how that's going to work while still respecting platform specific dropdown styling, hence I'm punting it for later. BUG=571500 Committed: https://crrev.com/33e728a7dcd5a0e2c60492899c97f49b8c922842 Cr-Commit-Position: refs/heads/master@{#392093}

Patch Set 1 #

Patch Set 2 : relative ps #

Patch Set 3 : checkpoint #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M ui/native_theme/common_theme.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M ui/views/controls/focusable_border.cc View 1 2 3 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Evan Stade
4 years, 7 months ago (2016-05-05 20:30:12 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931013002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931013002/60001
4 years, 7 months ago (2016-05-05 20:30:38 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 22:23:08 UTC) #7
sky
LGTM
4 years, 7 months ago (2016-05-05 23:21:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931013002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931013002/60001
4 years, 7 months ago (2016-05-06 17:57:28 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-06 18:02:18 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 18:03:43 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/33e728a7dcd5a0e2c60492899c97f49b8c922842
Cr-Commit-Position: refs/heads/master@{#392093}

Powered by Google App Engine
This is Rietveld 408576698