Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1931003002: Remove skstd::is_convertible. (Closed)

Created:
4 years, 7 months ago by bungeman-skia
Modified:
4 years, 7 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove skstd::is_convertible. We should now be able to use std::is_convertible. TBR=reed@google.com This doesn't change any API, just where we get a type trait from. Committed: https://skia.googlesource.com/skia/+/801b44c45348144a483793e7b24f4d4092a4f74d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -27 lines) Patch
M include/core/SkRefCnt.h View 5 chunks +5 lines, -4 lines 0 comments Download
M include/private/SkTLogic.h View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931003002/1
4 years, 7 months ago (2016-04-28 17:04:04 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 17:18:16 UTC) #6
bungeman-skia
Try to remove it now. If this causes something to fail somewhere, write revert and ...
4 years, 7 months ago (2016-04-28 17:59:31 UTC) #8
mtklein
lgtm
4 years, 7 months ago (2016-04-28 18:01:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931003002/1
4 years, 7 months ago (2016-04-28 18:01:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/9207)
4 years, 7 months ago (2016-04-28 18:03:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931003002/1
4 years, 7 months ago (2016-04-28 18:17:11 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 18:18:11 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/801b44c45348144a483793e7b24f4d4092a4f74d

Powered by Google App Engine
This is Rietveld 408576698