Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1931: Changed the Visual Studio project files to work when V8 is checked out... (Closed)

Created:
12 years, 3 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Changed the Visual Studio project files to work when V8 is checked out to a path containing spaces. BUG=55

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/visual_studio/v8.vcproj View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
12 years, 3 months ago (2008-09-11 07:49:39 UTC) #1
Mads Ager (chromium)
LGTM
12 years, 3 months ago (2008-09-11 07:53:42 UTC) #2
Søren Thygesen Gjesse
12 years, 3 months ago (2008-09-11 08:13:47 UTC) #3
On 2008/09/11 07:53:42, ager wrote:
> LGTM

Reissued as http://codereview.chromium.org/2416 due to changed username on
code.google.com/p/v8 and committed.

Powered by Google App Engine
This is Rietveld 408576698