Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1930943002: Revert of [Ignition] Test ignition on all bots. (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Ignition] Test ignition on all bots. (patchset #4 id:60001 of https://codereview.chromium.org/1804003002/ ) Reason for revert: Will resubmit with proper fix and more test skips. Original issue's description: > [Ignition] Test ignition on all bots. > > This adds ignition to the testing variants that are run on all > bots. > > Failing tests can only be skipped with the NO_IGNITION > keyword in status files. Existing expectations for the > ignition_turbofan variant are all duplicated and use the > NO_IGNITION keyword as well now. > > BUG=v8:4280 > LOG=N > NOTRY=true TBR=rmcilroy@chromium.org,mstarzinger@chromium.org,yangguo@chromium.org,mythria@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Committed: https://crrev.com/af41997177d046e7b52345d041c38da169a2af14 Cr-Commit-Position: refs/heads/master@{#35871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -179 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -72 lines 0 comments Download
M test/mjsunit/mjsunit.status View 5 chunks +0 lines, -80 lines 0 comments Download
M test/webkit/webkit.status View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/run-tests.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/testrunner/local/statusfile.py View 3 chunks +1 line, -7 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 4 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of [Ignition] Test ignition on all bots.
4 years, 7 months ago (2016-04-28 14:51:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930943002/1
4 years, 7 months ago (2016-04-28 14:51:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 14:51:35 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:43 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af41997177d046e7b52345d041c38da169a2af14
Cr-Commit-Position: refs/heads/master@{#35871}

Powered by Google App Engine
This is Rietveld 408576698