Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1930923002: [chrome.displaySource] Use a scoped enumeration for initialization steps. (Closed)

Created:
4 years, 7 months ago by e_hakkinen
Modified:
4 years, 7 months ago
Reviewers:
shalamov, Mikhail
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chrome.displaySource] Use a scoped enumeration for initialization steps. Use scoped enumerations for media pipeline initialization steps for better compiler support. BUG=242107 Committed: https://crrev.com/73f6a5d3fa11c3e526e85cec003d0f96d6c4de02 Cr-Commit-Position: refs/heads/master@{#392291}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.h View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.cc View 1 4 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
e_hakkinen
PTAL.
4 years, 7 months ago (2016-04-28 14:03:32 UTC) #2
Mikhail
lgtm
4 years, 7 months ago (2016-05-09 07:36:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930923002/20001
4 years, 7 months ago (2016-05-09 07:36:57 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 08:42:18 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 08:44:07 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/73f6a5d3fa11c3e526e85cec003d0f96d6c4de02
Cr-Commit-Position: refs/heads/master@{#392291}

Powered by Google App Engine
This is Rietveld 408576698