Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 1930913002: Remove oilpan build configuration vestiges. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove oilpan build configuration vestiges. With the updated GC clang plugin that rolled out as part of issue 604993, we no longer need to supply enable-oilpan to it. Stop doing so along with removing the enable_oilpan configuration option entirely. R=haraken,jochen BUG=585328 Committed: https://crrev.com/71408729cd1f5deca94fcdca3e7a46a6d03c38ba Cr-Commit-Position: refs/heads/master@{#390640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M third_party/WebKit/Source/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/build/features.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/config.gyp View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sof
please take a look; this will need toplevel owner approval, hence including tkent@. (Not dependent ...
4 years, 7 months ago (2016-04-28 14:19:28 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-04-28 14:21:22 UTC) #3
sof
+jochen@ as tkent@ might be OOO.
4 years, 7 months ago (2016-04-29 11:59:33 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-04-29 12:03:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930913002/1
4 years, 7 months ago (2016-04-29 12:47:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 14:02:51 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:25:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71408729cd1f5deca94fcdca3e7a46a6d03c38ba
Cr-Commit-Position: refs/heads/master@{#390640}

Powered by Google App Engine
This is Rietveld 408576698