 Chromium Code Reviews
 Chromium Code Reviews Issue 19309002:
  sync: Add pre-commit update avoidance mode + flag  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 19309002:
  sync: Add pre-commit update avoidance mode + flag  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: sync/internal_api/public/internal_components_factory.h | 
| diff --git a/sync/internal_api/public/internal_components_factory.h b/sync/internal_api/public/internal_components_factory.h | 
| index 6b79ddd2f936f0065a528b16cd570c0039f1da13..7220866b2eda9127724d42fb7025db3c0e8682d6 100644 | 
| --- a/sync/internal_api/public/internal_components_factory.h | 
| +++ b/sync/internal_api/public/internal_components_factory.h | 
| @@ -50,6 +50,16 @@ class SYNC_EXPORT InternalComponentsFactory { | 
| BACKOFF_SHORT_INITIAL_RETRY_OVERRIDE | 
| }; | 
| + enum PreCommitUpdatesPolicy { | 
| + // By default, the server will enable or disable this experiment through the | 
| + // sync protocol's experiments data type. | 
| + SERVER_CONTROLLED_PRE_COMMIT_UPDATE_AVOIANCE, | 
| + | 
| + // This flag overrides the server's decision and enables the pre-commit | 
| + // update avoidance experiment. | 
| + FORCE_ENABLE_PRE_COMMIT_UPDATE_AVOIDANCE, | 
| + }; | 
| + | 
| // Configuration options for internal components. This struct is expected | 
| // to grow and shrink over time with transient features / experiments, | 
| // roughly following command line flags in chrome. Implementations of | 
| @@ -58,6 +68,7 @@ class SYNC_EXPORT InternalComponentsFactory { | 
| struct Switches { | 
| EncryptionMethod encryption_method; | 
| BackoffOverride backoff_override; | 
| + PreCommitUpdatesPolicy pre_commit_updates_policy_override; | 
| 
tim (not reviewing)
2013/07/19 20:11:36
'override' seems superfluous in the name here.
 
rlarocque
2013/07/19 20:35:46
Done.
 | 
| }; | 
| virtual ~InternalComponentsFactory() {} |