Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 1930883002: V8: Turn xcode builder into xcode-ninja builder (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: Turn xcode builder into xcode-ninja builder Xcode is not officially supported by chromium, while the hybrid xcode-ninja is. Therefore we should make sure that the latter doesn't break. BUG=606898 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M scripts/slave/recipe_modules/v8/builders.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/v8/chromium_config.py View 1 chunk +6 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64___xcode.json View 2 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
PTAL
4 years, 7 months ago (2016-04-28 12:33:13 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-04-28 12:35:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930883002/1
4 years, 7 months ago (2016-04-28 12:37:33 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 12:40:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300276

Powered by Google App Engine
This is Rietveld 408576698