Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1930863003: Make SkTime SK_API so that SkTime::GetDateTime() is visible to the clients. (Closed)

Created:
4 years, 7 months ago by aam
Modified:
4 years, 7 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkTime SK_API so that SkTime::GetDateTime() is visible to the clients. # begin mtklein edits... No public API changes. TBR=reed@google.com # end mtklein edits BUG=skia:5230 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1930863003 Committed: https://skia.googlesource.com/skia/+/cf975447a8576740e682bfc4b8b91c2d8f95f64c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkTime.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
hal.canary
I can't approve changes to public headers. I think they lock down SkTime::GetDateTime on purpose.
4 years, 7 months ago (2016-05-02 20:50:00 UTC) #4
aam
On 2016/05/02 20:50:00, Hal Canary wrote: > I can't approve changes to public headers. > ...
4 years, 7 months ago (2016-05-02 21:46:09 UTC) #6
mtklein
lgtm
4 years, 7 months ago (2016-05-02 21:53:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930863003/1
4 years, 7 months ago (2016-05-02 21:53:41 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 22:04:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cf975447a8576740e682bfc4b8b91c2d8f95f64c

Powered by Google App Engine
This is Rietveld 408576698