Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1930813003: git-hyper-blame: Fix pagination (uses less if on a TTY). (Closed)

Created:
4 years, 7 months ago by Matt Giuca
Modified:
4 years, 7 months ago
Reviewers:
iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git-hyper-blame: Fix pagination (uses less if on a TTY). This was broken in r299682 (adding setup_color). git_hyper_blame now initializes setup_color. BUG=607771 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M git_hyper_blame.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Matt Giuca
4 years, 7 months ago (2016-04-29 01:30:24 UTC) #2
iannucci
lgtm, sorry about that.
4 years, 7 months ago (2016-04-29 01:31:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930813003/1
4 years, 7 months ago (2016-04-29 01:40:45 UTC) #5
Matt Giuca
No problem, thanks for quick review.
4 years, 7 months ago (2016-04-29 01:40:46 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 01:43:34 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300316

Powered by Google App Engine
This is Rietveld 408576698