chrome/app/mojo/chrome_manifest.json - Issue 1930813002: mash/chrome: Update manifest for exe:chrome.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/mojo/chrome_manifest.json

Issue 1930813002: mash/chrome: Update manifest for exe:chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 {	1 {

2 "manifest_version": 1,	2 "manifest_version": 1,

3 "name": "exe:chrome",	3 "name": "exe:chrome",

4 "display_name": "Chrome",	4 "display_name": "Chrome",

5 "capabilities": {	5 "capabilities": {

	6 "required": {

	7 "mojo:mus": {

	8 "interfaces": [

	9 "mus::mojom::WindowTreeFactory",
	Ben Goodger (Google) 2016/04/29 17:39:56 why was requesting "app" insufficient? That you ha why was requesting "app" insufficient? That you have to list these explicitly seems like a bug. sadrul 2016/04/29 17:43:28 This seems to be because mus manifest lists shell: Show quoted text On 2016/04/29 17:39:56, Ben Goodger (Google) wrote: > why was requesting "app" insufficient? That you have to list these explicitly > seems like a bug. This seems to be because mus manifest lists shell:explicit_class as required (although the requirement is for mojo:shell ... not sure if it's WAI that this affects exe:chrome too)
	10 "mus::mojom::Gpu",

	11 "mus::mojom::DisplayManager"

	12 ]

	13 },

	14 "*": { "classes": [ "app" ] }

	15 },

6 "provided": {	16 "provided": {

7 "mash:launchable": [ "mash::mojom::Launchable" ]	17 "mash:launchable": [ "mash::mojom::Launchable" ]

8 }	18 }

9 }	19 }

10 }	20 }

OLD	NEW

« no previous file with comments | « chrome/app/BUILD.gn ('k') | services/shell/shell.cc » ('j') | no next file with comments »